Remove duplicated publicPath

[karoldeland]

When specifying a publicPath in webpack config, the standalone plugin add the publicPath to the main script path. The public path is already included in mainScript.attributes.src.

Maybe caused by a newer version of another package?

We had to patch locally the StandaloneSingleSpaPlugin with this change to not have /publicPath/publicPath/mainscript.js

[joeldenning]

What version of webpack are you using? This plugin used to work with the latest version of webpack, so maybe the problem you're experiencing with v4 was caused by a change in webpack's behavior? If so, it should be documented in the Readme and possibly published as a new major version of standalone-single-spa-webpack-plugin.

[karoldeland]

Hi @joeldenning , currently using WebPack 5
"webpack": "^5.90.3",

Not tested with previous versions of webpack, but pretty sure you're right.

[joeldenning]

I added a test that confirms the bug and the fix. The tests use webpack 5.75.0 and the bug was present in that version, so the problem wasn't caused by a change in webpack's behavior

[joeldenning]

Removing the reference to publicPath in the modifyScripts function results in dead code within the apply function. This plugin currently supports multiple versions of html-webpack-plugin and I'm not sure if all versions would work with the updated changes here. Instead of testing each version, I'll just drop support for the older versions of html-webpack-plugin and publish this as a new major.

[joeldenning]

Published in 5.0.0. Thanks for your contribution.