Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making domElementGetter optional. Upgrading dependencies. #37

Merged
merged 1 commit into from
Jul 20, 2019
Merged

Making domElementGetter optional. Upgrading dependencies. #37

merged 1 commit into from
Jul 20, 2019

Conversation

joeldenning
Copy link
Member

This follows the convention established in single-spa-react, single-spa-angular, and single-spa-vue, of making domElementGetter optional.

@joeldenning joeldenning mentioned this pull request Jul 19, 2019
Merged
filoxo
filoxo approved these changes Jul 19, 2019
View reviewed changes
Copy link

@filoxo filoxo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 LGTM

@joeldenning joeldenning merged commit 5469759 into master Jul 20, 2019
@joeldenning joeldenning deleted the default-dom-el branch July 20, 2019 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filoxo filoxo filoxo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joeldenning @filoxo