Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide full ui unless local storage toggle is on #5

Closed
joeldenning opened this issue Jul 8, 2019 · 2 comments
Closed

Hide full ui unless local storage toggle is on #5

joeldenning opened this issue Jul 8, 2019 · 2 comments

Comments

@joeldenning
Copy link
Member

We should make it possible to turn off the import-map-overrides trigger unless a local storage flag is set
@joeldenning
Copy link
Member Author

Maybe through this API with the web component?

<import-map-overrides-full show-trigger-key="devMode"></import-map-overrides>

@joeldenning
Copy link
Member Author

ended up going with a different attribute name:

<import-map-overrides-full show-when-local-storage="overrides-ui"></import-map-overrides>

See docs

robmosca added a commit to travelperk/import-map-overrides that referenced this issue Jun 26, 2023
@robmosca
Add attribute to control the position of the trigger button (single-s…
2175885 
…pa#5)
robmosca added a commit to travelperk/import-map-overrides that referenced this issue Jul 21, 2023
@robmosca
Add attribute to control the position of the trigger button (single-s…
7c52acb 
…pa#5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joeldenning