Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Remove unnecessary steps from lint job #767

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Conversation

thetorpedodog
Copy link
Contributor

@thetorpedodog thetorpedodog commented Jan 20, 2023

Because pre-commit–based mypy doesn’t depend upon the packages in the installed directory, the only thing we need to install is pre-commit.

Context: #693

Because pre-commit–based mypy doesn’t depend upon the packages in the
installed directory, the only thing we need to install is pre-commit.
@codecov-commenter
Copy link

Codecov Report

Base: 78.69% // Head: 78.49% // Decreases project coverage by -0.20% ⚠️

Coverage data is based on head (f2ef83e) compared to base (190f216).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #767      +/-   ##
==========================================
- Coverage   78.69%   78.49%   -0.20%     
==========================================
  Files          30       30              
  Lines        2009     2009              
==========================================
- Hits         1581     1577       -4     
- Misses        428      432       +4     
Flag Coverage Δ
python 78.49% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apis/python/src/tiledbsoma/collection.py 84.32% <0.00%> (-1.63%) ⬇️
apis/python/src/tiledbsoma/sparse_nd_array.py 94.06% <0.00%> (-0.85%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@johnkerl johnkerl changed the title Remove unnecessary steps from lint job. [python] Remove unnecessary steps from lint job Jan 20, 2023
Copy link
Member

@atolopko-czi atolopko-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simpler still, nice!

@thetorpedodog thetorpedodog merged commit 8aac1e9 into main Jan 20, 2023
@thetorpedodog thetorpedodog deleted the pre-commit-only branch January 20, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants