[r] Caveat for TileDB-R dependency #764
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddelbuettel
suggested changes
Jan 19, 2023
| @@ -33,6 +33,9 @@ Imports: | |||
| Matrix, | |||
| stats, | |||
| bit64, | |||
| # We can't pin on 0.17.*, 0.18.*, etc since CRAN forbids it. This means that whenever tiledb-r | |||
| # bumps, we can have CI fails in the time window between that release and our bumping | |||
| # libtilesoma's core-dependency version. | |||
There was a problem hiding this comment.
-
We are not on CRAN. This is not a current binding constraint, and may not for some time. So why make it an issue.
-
One cannot leave comments in the DESCRIPTION file. Try
R CMD check .on any package where you add something like that. It will blow up immediately.
I suggest closing and withdrawing the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
Found via group debug regarding today's CI failures -- core 2.14 is out, and
tiledb-r0.18.0 is out (at CRAN), buttiledb-py0.20 is not yet and we haven't bumpedlibtiledbsoma's core dependency from 2.13 to 2.14 yet. So R CI fails withtiledb-rwriting a 2.14 array thatlibtiledbsomacan't read because it's a too-new version.See also #752