Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci/python] Dedupe PyPI stubs #704

Merged
merged 2 commits into from
Jan 12, 2023
Merged

[ci/python] Dedupe PyPI stubs #704

merged 2 commits into from
Jan 12, 2023

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Jan 12, 2023

This is a preliminary PR to go underneath the (now WIP) #701. (See also tracking issue #700.)

Unlike #701, it doesn't attempt to implement anything that doesn't currenly exist. Rather, it maintains the manual wheel flow from
https://github.com/single-cell-data/TileDB-SOMA/wiki/PyPI-packaging-WIP
and simply:

  • Removes a redundant step from python-ci.yml
  • Leaves CI per se in python-ci.yml and leaves Python package in python-packaging.yml
  • Updates the to-do stubs with my current understanding of where we're going

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2023

Codecov Report

Base: 71.70% // Head: 58.86% // Decreases project coverage by -12.84% ⚠️

Coverage data is based on head (72bd342) compared to base (9acb52c).
Patch has no changes to coverable lines.

❗ Current head 72bd342 differs from pull request most recent head 805a1af. Consider uploading reports for the commit 805a1af to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #704       +/-   ##
===========================================
- Coverage   71.70%   58.86%   -12.85%     
===========================================
  Files          70       38       -32     
  Lines        3768     1556     -2212     
===========================================
- Hits         2702      916     -1786     
+ Misses       1066      640      -426     
Flag Coverage Δ
python ?
r 58.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apis/python/src/tiledbsoma/tiledb_object.py
apis/python/src/tiledbsoma/collection.py
apis/python/src/tiledbsoma/logging.py
...python/src/tiledbsoma/experiment_query/__init__.py
apis/python/src/tiledbsoma/util_arrow.py
apis/python/src/tiledbsoma/somacore/data.py
...pis/python/src/tiledbsoma/experiment_query/axis.py
apis/python/src/tiledbsoma/somacore/__init__.py
apis/python/src/tiledbsoma/experiment.py
apis/python/src/tiledbsoma/io.py
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@thetorpedodog thetorpedodog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good overall but I defer to @mlin who is much better at this packaging thing than I am.

Copy link
Member

@mlin mlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM this comes down to just comments, right? To be clear, I definitely think we should automate the PyPI publishing once we're comfortable all the cibuildwheel stuff is working reliably and to our satisfaction. Now would be fine, except it will probably take a couple of hours of trial-and-error and maybe we're all juggling too much this week. Also happy to circle back on it later this month.

@johnkerl johnkerl merged commit f9c0808 into main Jan 12, 2023
@johnkerl johnkerl deleted the kerl/dedupe-pypi-stubs branch January 12, 2023 18:59
@johnkerl
Copy link
Member Author

this comes down to just comments

@mlin no, at https://github.com/single-cell-data/TileDB-SOMA/pull/704/files there are guidance (in the form of comments) as well as deduping -- removing no-longer-used (legacy from main-old) wheels stanza from python-ci.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants