-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci/python] Dedupe PyPI stubs #704
Conversation
Codecov ReportBase: 71.70% // Head: 58.86% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #704 +/- ##
===========================================
- Coverage 71.70% 58.86% -12.85%
===========================================
Files 70 38 -32
Lines 3768 1556 -2212
===========================================
- Hits 2702 916 -1786
+ Misses 1066 640 -426
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good overall but I defer to @mlin who is much better at this packaging thing than I am.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM this comes down to just comments, right? To be clear, I definitely think we should automate the PyPI publishing once we're comfortable all the cibuildwheel stuff is working reliably and to our satisfaction. Now would be fine, except it will probably take a couple of hours of trial-and-error and maybe we're all juggling too much this week. Also happy to circle back on it later this month.
@mlin no, at https://github.com/single-cell-data/TileDB-SOMA/pull/704/files there are guidance (in the form of comments) as well as deduping -- removing no-longer-used (legacy from |
This is a preliminary PR to go underneath the (now WIP) #701. (See also tracking issue #700.)
Unlike #701, it doesn't attempt to implement anything that doesn't currenly exist. Rather, it maintains the manual wheel flow from
https://github.com/single-cell-data/TileDB-SOMA/wiki/PyPI-packaging-WIP
and simply:
python-ci.yml
python-ci.yml
and leaves Python package inpython-packaging.yml