Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci/python] Don't build wheels on each PR push #697

Merged
merged 5 commits into from
Jan 11, 2023
Merged

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Jan 11, 2023

Context: #693, #700

Wheel builds can take 30-60 minutes, no longer necessary to run on each PR

@johnkerl johnkerl requested review from mlin and bkmartinjr January 11, 2023 17:09
workflow_dispatch:
# Normally the smoke test only runs on merge to main. To run it on a PR CI, uncomment `pull_request:`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any value in running it nightly (or every 2-3 days) just so we catch failures before doing a release?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkmartinjr indeed but I need to do a bit more research on syntax -- prefer to merge this now to reduce CI-resource burden

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracked on #693 which remains open

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will look like this:

  schedule:
    - cron: '30 1 * * *'  # Choose a random number 0–59 and 0–23 for these

Copy link
Member

@bkmartinjr bkmartinjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits in comments. Otherwise, am fine with change.

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2023

Codecov Report

Base: 71.70% // Head: 71.68% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (0ec0bcd) compared to base (3ad6cf7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #697      +/-   ##
==========================================
- Coverage   71.70%   71.68%   -0.03%     
==========================================
  Files          70       70              
  Lines        3768     3768              
==========================================
- Hits         2702     2701       -1     
- Misses       1066     1067       +1     
Flag Coverage Δ
python 80.69% <ø> (-0.05%) ⬇️
r 58.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apis/python/src/tiledbsoma/eta.py 89.47% <0.00%> (-2.64%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants