-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci/python] Don't build wheels on each PR push #697
Conversation
workflow_dispatch: | ||
# Normally the smoke test only runs on merge to main. To run it on a PR CI, uncomment `pull_request:` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any value in running it nightly (or every 2-3 days) just so we catch failures before doing a release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bkmartinjr indeed but I need to do a bit more research on syntax -- prefer to merge this now to reduce CI-resource burden
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tracked on #693 which remains open
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will look like this:
schedule:
- cron: '30 1 * * *' # Choose a random number 0–59 and 0–23 for these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits in comments. Otherwise, am fine with change.
Codecov ReportBase: 71.70% // Head: 71.68% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #697 +/- ##
==========================================
- Coverage 71.70% 71.68% -0.03%
==========================================
Files 70 70
Lines 3768 3768
==========================================
- Hits 2702 2701 -1
- Misses 1066 1067 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
7a645e5
to
d127cea
Compare
d127cea
to
0ec0bcd
Compare
Context: #693, #700
Wheel builds can take 30-60 minutes, no longer necessary to run on each PR