Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Do not require query condition columns in column_names #393

Merged
merged 4 commits into from
Oct 21, 2022

Conversation

gspowley
Copy link
Member

Based on TileDB-Inc/TileDB-Py#1333, remove the requirement to add attributes used in query conditions to the SOMAReader column_names.

@johnkerl
Copy link
Member

@gspowley I have a little bit of this in #400 (the query_condition.py part) and after that is merged I can add in the test_query_condition.py parts easily enough -- that is, I'm happy to finish off this almost-done PR if you like

@gspowley
Copy link
Member Author

Thanks @johnkerl. There's some work left on this PR to finish porting the solution from TileDB-Py. I added a (currently failing) test to highlight the issue.

@johnkerl johnkerl force-pushed the gspowley/query-condition-columns branch from 06c513b to 55e6ddf Compare October 20, 2022 19:35
@gspowley gspowley marked this pull request as ready for review October 21, 2022 18:50
@gspowley gspowley requested a review from johnkerl October 21, 2022 18:51
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@gspowley gspowley merged commit d8510b4 into main Oct 21, 2022
@gspowley gspowley deleted the gspowley/query-condition-columns branch October 21, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants