-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Re-enable tiledbsoma.ExperimentAxisQuery
#3476
Conversation
640675c
to
c61f7ec
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3476 +/- ##
==========================================
+ Coverage 86.27% 86.32% +0.04%
==========================================
Files 55 55
Lines 6339 6339
==========================================
+ Hits 5469 5472 +3
+ Misses 870 867 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two nits. no concern with intention of the PR, so pre-approving on the assumption the nits are easy to fix
cab2faa
to
e6d855b
Compare
e6d855b
to
4b81b1c
Compare
* [python] Re-enable `tiledbsoma.ExperimentAxisQuery` * Update unit-test case to use the user-facing API * code-review feedback * `somacore.Axis` and `tiledbsoma._query.Axis` are not the same thing * clarify a confusing internal name
* [python] Re-enable `tiledbsoma.ExperimentAxisQuery` * Update unit-test case to use the user-facing API * code-review feedback * `somacore.Axis` and `tiledbsoma._query.Axis` are not the same thing * clarify a confusing internal name Co-authored-by: John Kerl <[email protected]>
Issue and/or context: After 1.15.0 was tagged, we found that users can no longer instantiate
tiledbsoma.ExperimentAxisQuery
.Repro:
This should produce no output and raise no exceptions. Actual behavior in 1.15.0, which is a regression from 1.14.5:
Changes:
somacore
classes #3307 we moved the impl fromsomacore
totiledbsoma._query
, havetiledbsoma
re-export the impl from where it is now locatedtiledbsoma.ExperimentAxisQuery
Notes for Reviewer:
[sc-59686]