[python] Convert from Optional[Foo] to Foo | None
#3453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert `Optional` to [union types](https://docs.python.org/3/library/stdtypes.html#union-type) [SC-60887](https://app.shortcut.com/tiledb-inc/story/60887) resolves #3334
mojaveazure
force-pushed
the
paulhoffman/sc-60887/python-convert-from-optional-foo-to-foo-none
branch
from
ae736c4 to
5a411de
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3453 +/- ##
==========================================
+ Coverage 86.24% 86.32% +0.07%
==========================================
Files 55 55
Lines 6305 6339 +34
==========================================
+ Hits 5438 5472 +34
Misses 867 867
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mojaveazure
force-pushed
the
paulhoffman/sc-60887/python-convert-from-optional-foo-to-foo-none
branch
from
efa8011 to
30a0df3
Compare
johnkerl
approved these changes
Dec 17, 2024
mojaveazure
deleted the
paulhoffman/sc-60887/python-convert-from-optional-foo-to-foo-none
branch
github-actions bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
* [python] Convert from `Optional[Foo]` to `Foo | None` Convert `Optional` to [union types](https://docs.python.org/3/library/stdtypes.html#union-type) [SC-60887](https://app.shortcut.com/tiledb-inc/story/60887) resolves #3334 * Use union types in submodules * Use union types in tests * Use `Union[]` instead of `| None` * Use union types for top-level init files
johnkerl
pushed a commit
that referenced
this pull request
Dec 18, 2024
* [python] Convert from `Optional[Foo]` to `Foo | None` Convert `Optional` to [union types](https://docs.python.org/3/library/stdtypes.html#union-type) [SC-60887](https://app.shortcut.com/tiledb-inc/story/60887) resolves #3334 * Use union types in submodules * Use union types in tests * Use `Union[]` instead of `| None` * Use union types for top-level init files Co-authored-by: Paul Hoffman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert
Optionalto union typesSC-60887
resolves #3334