Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Rename to_spatial_data -> to_spatialdata #3449

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

jp-dark
Copy link
Collaborator

@jp-dark jp-dark commented Dec 16, 2024

Change name of methods that contain to_spatial_data to to_spatialdata.

@jp-dark jp-dark requested a review from johnkerl December 16, 2024 15:56
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.29%. Comparing base (b30dd60) to head (7fc6ca0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3449      +/-   ##
==========================================
+ Coverage   86.22%   86.29%   +0.06%     
==========================================
  Files          55       55              
  Lines        6295     6305      +10     
==========================================
+ Hits         5428     5441      +13     
+ Misses        867      864       -3     
Flag Coverage Δ
python 86.29% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 86.29% <100.00%> (+0.06%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@jp-dark jp-dark merged commit 1fa2666 into main Dec 16, 2024
12 checks passed
@jp-dark jp-dark deleted the dark/rename-spatial-data branch December 16, 2024 16:42
Copy link

The backport to release-1.15 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-1.15 release-1.15
# Navigate to the new working tree
cd .worktrees/backport-release-1.15
# Create a new branch
git switch --create backport-3449-to-release-1.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 1fa2666e3f324760c2cc57ae0b19be369295b26e
# Push it to GitHub
git push --set-upstream origin backport-3449-to-release-1.15
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-1.15

Then, create a pull request where the base branch is release-1.15 and the compare/head branch is backport-3449-to-release-1.15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants