-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Fix conditional fall-through in SOMAObject.open
#3446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3446 +/- ##
==========================================
+ Coverage 86.22% 86.29% +0.06%
==========================================
Files 55 55
Lines 6295 6305 +10
==========================================
+ Hits 5428 5441 +13
+ Misses 867 864 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bkmartinjr
approved these changes
Dec 15, 2024
johnkerl
approved these changes
Dec 16, 2024
johnkerl
requested changes
Dec 16, 2024
johnkerl
approved these changes
Dec 17, 2024
johnkerl
pushed a commit
that referenced
this pull request
Dec 17, 2024
…3454) Co-authored-by: nguyenv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
As reported internally, the pybind11 implemented
SOMAObject.open
contains a conditional fall-through as of #3402.Changes:
Wrap the C++ call in try-catch block where
SOMAObject::open
should already throw an exception for unknown types. In the Pybind11 code, if the conditional falls through then trigger anassert
for unreachable code.