[c++] Fix bug with sliced Arrow-table writes, with string columns #3433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
force-pushed
the
kerl/arrow-table-slice
branch
from
2356f18 to
faf5071
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3433 +/- ##
==========================================
+ Coverage 86.03% 86.27% +0.24%
==========================================
Files 55 55
Lines 6278 6295 +17
==========================================
+ Hits 5401 5431 +30
+ Misses 877 864 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jp-dark
reviewed
Dec 13, 2024
| if (array->n_buffers == 3) { | ||
| buf = (UserType*)array->buffers[2] + array->offset; | ||
| } else { | ||
| buf = (UserType*)array->buffers[1] + array->offset; | ||
| } | ||
| uint8_t* validity = (uint8_t*)array->buffers[0]; |
There was a problem hiding this comment.
Nit: This would be a good opportunity to move away from the C-style cast to a named cast (static_cast in this case).
jp-dark
reviewed
Dec 13, 2024
Comment on lines
+970
to
+971
| // * Whether the column (array) has 3 buffers (validity, offset, data) | ||
| // or 2 (validity, data). |
There was a problem hiding this comment.
I found this comment confusing since we throw if the column (array) doesn't have 3 buffers.
jp-dark
approved these changes
Dec 13, 2024
johnkerl
added a commit
that referenced
this pull request
Dec 13, 2024
) (#3436) Co-authored-by: John Kerl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: #3432 [sc-60767]
Changes:
As described on #3432.
Also, an existing test-case, that might have caught the problem sooner but did not, did not test string columns. That has been modified to also test string columns.
Notes for Reviewer: