[c++] Column abstraction: SOMAAttribute, part 2
#3426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt domain checks, replace vector with span when selecting points
XanthosXanthopoulos
changed the title
SOMAAttribute, part 2
johnkerl
requested changes
Dec 12, 2024
| class SOMAAttribute : public virtual SOMAColumn { | ||
| public: | ||
| /** | ||
| * Create a ``SOMAAttribute`` shared pointer from an arrow schema |
There was a problem hiding this comment.
Suggested change
| * Create a ``SOMAAttribute`` shared pointer from an arrow schema | |
| * Create a ``SOMAAttribute`` shared pointer from an Arrow schema |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce the
SOMAAttributeconcrete class to wrap TIleDBAttributeandEnumerationpairs.