-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[c++] Column abstraction: SOMADimension
, part 1
#3425
Open
XanthosXanthopoulos
wants to merge
19
commits into
xan/sc-59427/arrow-helpers
Choose a base branch
from
xan/sc-sc-59427/soma-dimension
base: xan/sc-59427/arrow-helpers
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
4778cb4
Add helper methods for to and from arrow contructs
XanthosXanthopoulos 2c9955a
SOMAColumn abstract class definition
XanthosXanthopoulos 6d0b9f9
Remove fmt::format
XanthosXanthopoulos 911d005
Remove unneeded methods and member variables
XanthosXanthopoulos 5c997d5
Add concrete class wrapper for TileDB dimension
XanthosXanthopoulos 7fb9329
Add minimal testing for dimensions
XanthosXanthopoulos a5b81d5
Misc fixes
XanthosXanthopoulos dca737c
Add read test case
XanthosXanthopoulos 883fc85
Add missing `override`
XanthosXanthopoulos 3dd3c90
Remove current_domain flag
XanthosXanthopoulos 904d799
Add virtual destructor [skip ci]
XanthosXanthopoulos 902b073
Bump min macos version (Remove commit after merging 3361)
XanthosXanthopoulos 0a7d54e
Replace string_view with string when returning column name, add curre…
XanthosXanthopoulos 698e36e
Fix unit test
XanthosXanthopoulos 9b6a2d5
Add better description to SOMACOlumn
XanthosXanthopoulos 61a5b05
Add description and license
XanthosXanthopoulos 0ad22da
Address review comments
XanthosXanthopoulos ead3bde
Fix unit tests
XanthosXanthopoulos 8fb7390
Remove duplicate declaration
XanthosXanthopoulos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
/** | ||
* @file soma_column.cc | ||
* | ||
* @section LICENSE | ||
* | ||
* The MIT License | ||
* | ||
* @copyright Copyright (c) 2024 TileDB, Inc. | ||
* | ||
* Permission is hereby granted, free of charge, to any person obtaining a copy | ||
* of this software and associated documentation files (the "Software"), to deal | ||
* in the Software without restriction, including without limitation the rights | ||
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
* copies of the Software, and to permit persons to whom the Software is | ||
* furnished to do so, subject to the following conditions: | ||
* | ||
* The above copyright notice and this permission notice shall be included in | ||
* all copies or substantial portions of the Software. | ||
* | ||
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
* THE SOFTWARE. | ||
* | ||
* @section DESCRIPTION | ||
* | ||
* This file defines the SOMAColumn class. | ||
*/ | ||
|
||
#include "soma_column.h" | ||
|
||
namespace tiledbsoma { | ||
|
||
template <> | ||
std::pair<std::string, std::string> SOMAColumn::core_domain_slot<std::string>() | ||
const { | ||
return std::pair<std::string, std::string>("", ""); | ||
} | ||
|
||
template <> | ||
std::pair<std::string, std::string> | ||
SOMAColumn::core_current_domain_slot<std::string>( | ||
const SOMAContext& ctx, Array& array) const { | ||
try { | ||
std::pair<std::string, std::string> | ||
current_domain = std::any_cast<std::pair<std::string, std::string>>( | ||
_core_current_domain_slot(ctx, array)); | ||
|
||
if (current_domain.first == "" && (current_domain.second == "\x7f" || | ||
current_domain.second == "\xff")) { | ||
return std::pair<std::string, std::string>("", ""); | ||
} | ||
|
||
return current_domain; | ||
} catch (const std::exception& e) { | ||
throw TileDBSOMAError(e.what()); | ||
} | ||
} | ||
} // namespace tiledbsoma |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a comment here about why both
\x7f
and\xff
-- it needs to be retained. This is very confusing without that comment. (Which is why I put the comment in.)TileDB-SOMA/libtiledbsoma/src/soma/soma_array.h
Lines 901 to 920 in a8349a5