[c++] ManagedQuery::set_condition should not reset entire instance state
#3418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkmartinjr
changed the title
johnkerl
changed the title
ManagedQuery::set_condition should not reset entire instance state
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3418 +/- ##
==========================================
+ Coverage 85.99% 86.09% +0.09%
==========================================
Files 55 55
Lines 6221 6221
==========================================
+ Hits 5350 5356 +6
+ Misses 871 865 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nguyenv
approved these changes
Dec 11, 2024
johnkerl
approved these changes
Dec 11, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 11, 2024
…state (#3418) * set_condition should not reset entire instance state * lint * rework ManagedQuery API a bit * lint
johnkerl
pushed a commit
that referenced
this pull request
Dec 11, 2024
…state (#3418) (#3420) * set_condition should not reset entire instance state * lint * rework ManagedQuery API a bit * lint Co-authored-by: Bruce Martin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
The new
ManagedQueryclassset_conditionmethod was resetting all instance state. This had the side-effect of losing layout and other query params for anyManagedQuerywith a query condition.