[c++] Fix upgrade-soma-joinid-shape for dataframes having non-standard dimensions

[johnkerl]

Issue and/or context: As tracked on issue #2407 / [sc-51048]. Also #3417.

Changes:

There should be a closing curly brace here:

TileDB-SOMA/libtiledbsoma/src/soma/soma_array.cc

Line 1042 in cbfa704

and not here:

TileDB-SOMA/libtiledbsoma/src/soma/soma_array.cc

Line 1144 in cbfa704

}

As this correctly describes

TileDB-SOMA/libtiledbsoma/src/soma/soma_array.cc

Lines 1024 to 1025 in cbfa704

	// For upgrade: copy from the full/wide/max domain except for the
	// soma_joinid restriction.

we need to be copying from core domain (soma maxdomain) to core current domain (soma domain) for all the other dims.

One problem is that the only remaining code which tests this (now that we aren't creating new arrays without current domain anymore) is in

TileDB-SOMA/apis/python/tests/test_shape.py

Line 434 in cbfa704

def test_canned_experiments(tmp_path, has_shapes):

-- and the "canned" (saved-off) pre-1.15 xexperiments only have dataframes that are 'standard' i.e. soma_joinid is their only dim.

i'll add some pre-1.15 data to test this.

Notes for Reviewer:

When this PR is ready for review, please review it with
https://github.com/single-cell-data/TileDB-SOMA/pull/3416/files?diff=split&w=1 (edited)
as that will not flag whitespace as red/green, and this PR is (a) just moving a curly brace, with concomitant indentation change, and (b) additional unit-test coverage.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.09%. Comparing base (cbfa704) to head (e048cce).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3416      +/-   ##
==========================================
+ Coverage   85.99%   86.09%   +0.09%     
==========================================
  Files          55       55              
  Lines        6221     6221              
==========================================
+ Hits         5350     5356       +6     
+ Misses        871      865       -6     

Flag	Coverage Δ
python	86.09% <ø> (+0.09%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
python_api	86.09% <ø> (+0.09%)	⬆️
libtiledbsoma	∅ <ø> (∅)