[python] Fix output type when exporting PointCloudDataFrame
to SpatialData points
#3408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of
to_spatial_data_points
was exporting data to a pandasDataFrame
, but SpatialData expected a daskDataFrame
. This type error was not caught in the tests usingspatialdata.models.PointsModel.validate
. This fixes the tests to check the type along with additional validataion by usingspatialdata.models.get_model
instead of thevalidate
methods, and updates the exporter to return the correct type.