-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python/r] Update docstrings for domain
argument to create
#3396
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3396 +/- ##
==========================================
+ Coverage 85.85% 85.94% +0.09%
==========================================
Files 55 55
Lines 6199 6199
==========================================
+ Hits 5322 5328 +6
+ Misses 877 871 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
0a89bb6
to
9361992
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on the R side, please remember to update the docs with devtools::document()
@ryan-williams I'd love a second pair of 👀 for the Python side -- if you haven't time, that's fine, I'll need to merge by say mid-day tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple questions about the Python docstr
#3398 tracks the CI break which was not caused by this docstring-only PR. |
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.