Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python/r] Update docstrings for domain argument to create #3396

Merged
merged 7 commits into from
Dec 4, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Dec 3, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

@johnkerl johnkerl marked this pull request as ready for review December 3, 2024 20:35
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.94%. Comparing base (0ce5ac9) to head (062008d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3396      +/-   ##
==========================================
+ Coverage   85.85%   85.94%   +0.09%     
==========================================
  Files          55       55              
  Lines        6199     6199              
==========================================
+ Hits         5322     5328       +6     
+ Misses        877      871       -6     
Flag Coverage Δ
python 85.94% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 85.94% <ø> (+0.09%) ⬆️
libtiledbsoma ∅ <ø> (∅)

apis/r/R/SOMADataFrame.R Outdated Show resolved Hide resolved
@johnkerl johnkerl requested a review from mojaveazure December 3, 2024 23:02
@johnkerl johnkerl force-pushed the kerl/domain-at-create-docstrings branch from 0a89bb6 to 9361992 Compare December 3, 2024 23:04
Copy link
Member

@mojaveazure mojaveazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the R side, please remember to update the docs with devtools::document()

@johnkerl
Copy link
Member Author

johnkerl commented Dec 3, 2024

@ryan-williams I'd love a second pair of 👀 for the Python side -- if you haven't time, that's fine, I'll need to merge by say mid-day tomorrow

Copy link
Member

@ryan-williams ryan-williams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple questions about the Python docstr

apis/python/src/tiledbsoma/_dataframe.py Outdated Show resolved Hide resolved
@johnkerl
Copy link
Member Author

johnkerl commented Dec 4, 2024

#3398 tracks the CI break which was not caused by this docstring-only PR.

@johnkerl johnkerl merged commit ee8e967 into main Dec 4, 2024
9 of 12 checks passed
@johnkerl johnkerl deleted the kerl/domain-at-create-docstrings branch December 4, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants