Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Some use_current_domain unit-test/feature-flag teardown, part 4 of 4 #3372

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Nov 22, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048]. Also #3273.

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

Notes for Reviewer:

This is fourth in a series of PRs. While the changes are trivial, the line-count can be intimidating when it's attempted all at once.

Stacked on #3371

The line count is big but mostly whitespace. Suggestion: hide whitespace when reviewing:
https://github.com/single-cell-data/TileDB-SOMA/pull/3372/files?diff=split&w=1

@johnkerl johnkerl changed the title [c++] Some use_current_domain unit-test/feature-flag teardown, part 4/n [c++] Some use_current_domain unit-test/feature-flag teardown, part 4 of 4 Nov 22, 2024
@johnkerl johnkerl changed the title [c++] Some use_current_domain unit-test/feature-flag teardown, part 4 of 4 [c++] Some use_current_domain unit-test/feature-flag teardown, part 4 of 4 Nov 22, 2024
@johnkerl johnkerl force-pushed the kerl/ucd3 branch 2 times, most recently from eb0b721 to b6bcaac Compare November 22, 2024 15:24
Base automatically changed from kerl/ucd3 to main November 22, 2024 16:16
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.15%. Comparing base (937b43d) to head (8bfc49a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3372       +/-   ##
===========================================
+ Coverage   66.94%   86.15%   +19.20%     
===========================================
  Files         139       55       -84     
  Lines       17727     6094    -11633     
  Branches     1063        0     -1063     
===========================================
- Hits        11868     5250     -6618     
+ Misses       5483      844     -4639     
+ Partials      376        0      -376     
Flag Coverage Δ
libtiledbsoma ?
python 86.15% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 86.15% <ø> (+0.09%) ⬆️
libtiledbsoma ∅ <ø> (∅)
---- 🚨 Try these New Features:

@johnkerl johnkerl merged commit 93c9681 into main Nov 22, 2024
15 checks passed
@johnkerl johnkerl deleted the kerl/ucd4 branch November 22, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants