Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Update Scene create method in the Python API #3356

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

jp-dark
Copy link
Collaborator

@jp-dark jp-dark commented Nov 20, 2024

  1. Add spatial disclaimer as warning.
  2. Implement writing the coordinate space at create.
  3. Use Scene C++ code instead of going through Python superclass.
    • Requires updating Scene C++ create method to match behavior of existing code (do not create obsl/varl/img at create).

1. Add spatial disclaimer as warning.
2. Implement writing the coordinate sapce at create.
3. Use Scene C++ code instead of going through Python super class.
   * Requires updating Scene C++ create method to match behavior of
     existing code (do not create obsl/varl/img at create).
@jp-dark
Copy link
Collaborator Author

jp-dark commented Nov 20, 2024

sc-58718

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.92%. Comparing base (b6af5d7) to head (84c72ae).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3356      +/-   ##
==========================================
+ Coverage   85.65%   85.92%   +0.27%     
==========================================
  Files          57       55       -2     
  Lines        6203     6189      -14     
==========================================
+ Hits         5313     5318       +5     
+ Misses        890      871      -19     
Flag Coverage Δ
python 85.92% <88.88%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 85.92% <88.88%> (+0.27%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@jp-dark jp-dark requested a review from johnkerl November 27, 2024 15:05
@jp-dark jp-dark merged commit 7bcf4a8 into main Nov 27, 2024
15 checks passed
@jp-dark jp-dark deleted the dark/scene-coordspace-on-create/sc-58718 branch November 27, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants