Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Use std::format in spdlog (C++ 20) #3343

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

XanthosXanthopoulos
Copy link
Collaborator

@XanthosXanthopoulos XanthosXanthopoulos commented Nov 19, 2024

When compiling with gcc >13 several error related to fmt::format occur when building spdlog. Forcing the use of std::format resolves them.

Context: #3154 [sc-57301]

Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.76%. Comparing base (c57ccc0) to head (123ca04).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3343      +/-   ##
==========================================
+ Coverage   85.71%   85.76%   +0.04%     
==========================================
  Files          57       57              
  Lines        6169     6180      +11     
==========================================
+ Hits         5288     5300      +12     
+ Misses        881      880       -1     
Flag Coverage Δ
python 85.76% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 85.76% <ø> (+0.04%) ⬆️
libtiledbsoma ∅ <ø> (∅)
---- 🚨 Try these New Features:

@XanthosXanthopoulos XanthosXanthopoulos merged commit 67213c9 into main Nov 19, 2024
35 checks passed
@XanthosXanthopoulos XanthosXanthopoulos deleted the xan/use-std-format-in-spdlog branch November 19, 2024 22:43
@johnkerl johnkerl changed the title [c++] Use std::format in spdlog [c++] Use std::format in spdlog (C++ 20) Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants