Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++/python] Switch to std::span #3340

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

XanthosXanthopoulos
Copy link
Collaborator

@XanthosXanthopoulos XanthosXanthopoulos commented Nov 19, 2024

Continuing the migration to C++20, this PR replaces tcb::span with std::span

Context: #3154 [sc-57301]

@johnkerl johnkerl changed the title [c++/python] Switch to std::span [c++/python] Switch to std::span Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.63%. Comparing base (f5a3dbc) to head (5d9dfff).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3340      +/-   ##
==========================================
+ Coverage   85.53%   85.63%   +0.10%     
==========================================
  Files          54       54              
  Lines        5703     5703              
==========================================
+ Hits         4878     4884       +6     
+ Misses        825      819       -6     
Flag Coverage Δ
python 85.63% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 85.63% <ø> (+0.10%) ⬆️
libtiledbsoma ∅ <ø> (∅)
---- 🚨 Try these New Features:

Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XanthosXanthopoulos I know you still have this as draft, but, since CI is green, and with respect for timezone skew I've gone ahead and approved it so it'll be ready for you to merge in your morning.

Thanks for doing this! :)

@XanthosXanthopoulos XanthosXanthopoulos marked this pull request as ready for review November 19, 2024 20:15
@XanthosXanthopoulos XanthosXanthopoulos merged commit c57ccc0 into main Nov 19, 2024
15 checks passed
@XanthosXanthopoulos XanthosXanthopoulos deleted the xan/sc-57301/switch-to-std-span branch November 19, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants