-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[c++/python/r] Migrate to C++20 #3331
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3331 +/- ##
==========================================
+ Coverage 85.14% 85.51% +0.36%
==========================================
Files 53 54 +1
Lines 5568 5703 +135
==========================================
+ Hits 4741 4877 +136
+ Misses 827 826 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
491d288
to
a70f43e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is in draft and you haven't submitted it for review yet. :)
However -- CI is green and this is delightful work. I'm approving it in advance. Especially with regard to timezone alignment.
Feel free to merge this when you're ready.
Thanks again for doing this!!! :)
One note and cc @mojaveazure -- given that there are compile errors if TileDB-SOMA/apis/r/DESCRIPTION Line 52 in 75112e5
RcppSpdlog when users upgrade their tiledbsoma version (once we tag 1.15.0)?
|
I don't think this matters. In R, the "hard" dependencies are Moreover, R and CRAN allow all types of dependencies ( |
OK thank you @mojaveazure ! I did get an error on my laptop until I upgraded So since @mojaveazure asserts that |
This PR migrates minimum C++ version to C++20 and replaces
fmt::format
with the now availablestd::format
Context: #3154 [sc-57301]