[python] _multiscale_image: add missing docstrings, typo fixes
#3312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-williams
commented
Nov 8, 2024
| @@ -151,6 +151,11 @@ def create( | |||
| axis is provided, this defaults to the channel axis followed by the | |||
| coordinate space axes in reverse order (e.g. | |||
| ``("soma_channel", "y", "x")`` if ``coordinate_space=("x", "y")``). | |||
| has_channel_axis: Save the image with a dedicated "channel" axis. | |||
There was a problem hiding this comment.
@jp-dark mentioned the has_channel_axis arg may go away. This can be sequenced before or after that, afaic.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3312 +/- ##
===========================================
+ Coverage 65.59% 85.49% +19.89%
===========================================
Files 137 52 -85
Lines 17111 5508 -11603
Branches 1067 0 -1067
===========================================
- Hits 11224 4709 -6515
+ Misses 5583 799 -4784
+ Partials 304 0 -304
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jp-dark
approved these changes
Nov 8, 2024
johnkerl
changed the title
_multiscale_image: add missing docstrs, typo fixes_multiscale_image: add missing docstrings, typo fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.