-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Fix some dense+2.27 failing test cases #3265
Conversation
@@ -35,7 +35,7 @@ SOMADenseNDArray <- R6::R6Class( | |||
read_arrow_table = function( | |||
coords = NULL, | |||
result_order = "auto", | |||
log_level = "warn" | |||
log_level = "auto" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this meant to be included in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it was -- I should have commented. It actually overrides the environment variable SPDLOG_LEVEL
and makes requested log statements NOT appear :(. This has already been fixed for other classes except this one. I thought this was a nice little thing to include in this 'misc. bits' PR.
Sorry for the lack of clarity!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3265 +/- ##
==========================================
+ Coverage 83.80% 83.90% +0.10%
==========================================
Files 51 51
Lines 5563 5567 +4
==========================================
+ Hits 4662 4671 +9
+ Misses 901 896 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Issue and/or context: As tracked on issue #2407 / [sc-51048]. See also #3364.
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
We've had current-domain support since core 2.26 for core sparse arrays: soma
DataFrame
andSparseNDArray
. We don't have it forDenseNDArray
until core 2.27, which isn't released yet.This is tested using @jdblischak 's nightlies as tracked here: TileDB-Inc/centralized-tiledb-nightlies#25. It can also be tested by doing a from-source core install on a laptop -- which is what I do on one of my laptops.
There are some larger issues to be fixed, which I've done piecemeal on to-be-abandoned #3244. There is also a single large issue to be fixed on #3263. Meanwhile, this PR fixes a few one-off issues.
Notes for Reviewer: