Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Fix some dense+2.27 failing test cases #3265

Merged
merged 8 commits into from
Oct 30, 2024
Merged

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Oct 30, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048]. See also #3364.

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

We've had current-domain support since core 2.26 for core sparse arrays: soma DataFrame and SparseNDArray. We don't have it for DenseNDArray until core 2.27, which isn't released yet.

This is tested using @jdblischak 's nightlies as tracked here: TileDB-Inc/centralized-tiledb-nightlies#25. It can also be tested by doing a from-source core install on a laptop -- which is what I do on one of my laptops.

There are some larger issues to be fixed, which I've done piecemeal on to-be-abandoned #3244. There is also a single large issue to be fixed on #3263. Meanwhile, this PR fixes a few one-off issues.

Notes for Reviewer:

@@ -35,7 +35,7 @@ SOMADenseNDArray <- R6::R6Class(
read_arrow_table = function(
coords = NULL,
result_order = "auto",
log_level = "warn"
log_level = "auto"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this meant to be included in this PR?

Copy link
Member Author

@johnkerl johnkerl Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it was -- I should have commented. It actually overrides the environment variable SPDLOG_LEVEL and makes requested log statements NOT appear :(. This has already been fixed for other classes except this one. I thought this was a nice little thing to include in this 'misc. bits' PR.

Sorry for the lack of clarity!

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.90%. Comparing base (7a9c67e) to head (c27b2e6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3265      +/-   ##
==========================================
+ Coverage   83.80%   83.90%   +0.10%     
==========================================
  Files          51       51              
  Lines        5563     5567       +4     
==========================================
+ Hits         4662     4671       +9     
+ Misses        901      896       -5     
Flag Coverage Δ
python 83.90% <73.33%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 83.90% <73.33%> (+0.10%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl merged commit 130ccc6 into main Oct 30, 2024
14 checks passed
@johnkerl johnkerl deleted the kerl/dense-227-a branch October 30, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants