Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Rename set_reader_coords to set_coords #3253

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

johnkerl
Copy link
Member

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

@nguyenv mentioned the other doing this. However while working on #3244 I realized it was a good deconfuse for me to go ahead and do this sooner than later.

Notes for Reviewer:

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.90%. Comparing base (50c5d71) to head (ae18f34).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3253      +/-   ##
==========================================
+ Coverage   83.79%   83.90%   +0.10%     
==========================================
  Files          51       51              
  Lines        5560     5560              
==========================================
+ Hits         4659     4665       +6     
+ Misses        901      895       -6     
Flag Coverage Δ
python 83.90% <91.66%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 83.90% <91.66%> (+0.10%) ⬆️
libtiledbsoma ∅ <ø> (∅)

Copy link
Member

@nguyenv nguyenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@johnkerl johnkerl merged commit 2be2864 into main Oct 29, 2024
11 checks passed
@johnkerl johnkerl deleted the kerl/set-coords-rename branch October 29, 2024 19:58
github-actions bot pushed a commit that referenced this pull request Oct 29, 2024
johnkerl added a commit that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants