Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r] Support for dense current domain with core 2.27 #3180

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Oct 16, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048]. See also #3364.

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

Notes for Reviewer:

Sibling of #3179

@johnkerl johnkerl marked this pull request as ready for review October 16, 2024 17:16
@johnkerl johnkerl requested a review from mojaveazure October 16, 2024 17:16
@johnkerl johnkerl force-pushed the kerl/r-dense-curdom branch from 5b85e9b to 5e9ebc0 Compare October 16, 2024 17:17
@johnkerl johnkerl removed the request for review from mojaveazure October 16, 2024 17:47
@johnkerl johnkerl marked this pull request as draft October 16, 2024 17:47
@johnkerl johnkerl marked this pull request as ready for review October 16, 2024 19:04
@johnkerl johnkerl requested a review from mojaveazure October 16, 2024 19:04
Base automatically changed from kerl/fixes-for-2-27 to main October 16, 2024 20:06
@johnkerl johnkerl force-pushed the kerl/r-dense-curdom branch from 42c8e3c to ac586cc Compare October 16, 2024 20:46
Copy link
Member

@mojaveazure mojaveazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; please update the changelog, bump the develop version, and 🚢

@johnkerl johnkerl merged commit 7683e1e into main Oct 17, 2024
4 checks passed
@johnkerl johnkerl deleted the kerl/r-dense-curdom branch October 17, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants