Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fatal on 1.15-related assertions #3137

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Oct 4, 2024

1.15.0rc0 was failing post-merge CI with things like

>       assert (int(version[0]), int(version[1])) < (major, minor)
E       AssertionError

https://github.com/single-cell-data/TileDB-SOMA/actions/runs/11187321846/job/31104123666

@johnkerl johnkerl requested a review from nguyenv October 4, 2024 22:44
@johnkerl johnkerl force-pushed the kerl/rc0-deprecation-update branch from 70fd919 to 07af03e Compare October 4, 2024 22:46
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.52%. Comparing base (26b8929) to head (07af03e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3137      +/-   ##
==========================================
+ Coverage   82.49%   82.52%   +0.03%     
==========================================
  Files          50       50              
  Lines        5204     5203       -1     
==========================================
+ Hits         4293     4294       +1     
+ Misses        911      909       -2     
Flag Coverage Δ
python 82.52% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 82.52% <100.00%> (+0.03%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl merged commit 7018462 into main Oct 4, 2024
11 checks passed
@johnkerl johnkerl deleted the kerl/rc0-deprecation-update branch October 4, 2024 23:19
johnkerl added a commit that referenced this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants