Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] Update coordinate space <-> JSON converters #3114

Merged
merged 2 commits into from
Oct 2, 2024
Merged

[python] Update coordinate space <-> JSON converters #3114

merged 2 commits into from
Oct 2, 2024

Conversation

nguyenv
Copy link
Member

@nguyenv nguyenv commented Oct 2, 2024

Cherry picking d0eb046 to main from #3101 (which has been merged to spatial).

@nguyenv
[python] Update coordinate space <-> JSON converters
d0eb046 
* Update `transform_from_json` and `transform_to_json` to support
  additional `CoordinateSpace` types `UniformScaleTransform` and
  `ScaleTransform`
@nguyenv nguyenv requested a review from jp-dark October 2, 2024 14:57
@codecov Codecov
Copy link

codecov bot commented Oct 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 46.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 88.22%. Comparing base (897fa0e) to head (08ad6c2).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3114      +/-   ##
==========================================
+ Coverage   88.14%   88.22%   +0.07%     
==========================================
  Files          47       47              
  Lines        4589     4593       +4     
==========================================
+ Hits         4045     4052       +7     
+ Misses        544      541       -3
Flag Coverage Δ
python 88.22% <46.66%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 88.22% <46.66%> (+0.07%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@nguyenv @jp-dark
Correct documentation
08ad6c2 
Co-authored-by: Julia Dark <[email protected]>
jp-dark
jp-dark approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@jp-dark jp-dark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit on adding back the "dataframe" to "point cloud dataframe", but everything else looks good.

@nguyenv nguyenv requested a review from jp-dark October 2, 2024 17:30
@nguyenv nguyenv merged commit eb89c31 into main Oct 2, 2024
9 checks passed
@nguyenv nguyenv deleted the viviannguyen/cherry-pick-spatial-util-changes branch October 2, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jp-dark jp-dark Awaiting requested review from jp-dark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nguyenv @jp-dark