Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++/python] Check arrow_is_string_type in _update_dataframe #3111

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

nguyenv
Copy link
Member

@nguyenv nguyenv commented Oct 1, 2024

  • Rename ArrowAdapter::_isvar to ArrowAdapter::arrow_is_string_type and expose in public API
  • In pybind11 SOMAArray._update_dataframe, check if the Arrow column's type is a string type and set the Attr's cell value to TILEDB_VAR_NUM if so

@nguyenv nguyenv requested a review from johnkerl October 1, 2024 22:09
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢
Thank you @nguyenv ! :)

@johnkerl
Copy link
Member

johnkerl commented Oct 1, 2024

Note: found on R-side debug on #3057

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.27%. Comparing base (db97b07) to head (77725d6).
Report is 85 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3111      +/-   ##
==========================================
- Coverage   88.95%   88.27%   -0.69%     
==========================================
  Files          45       47       +2     
  Lines        4293     4589     +296     
==========================================
+ Hits         3819     4051     +232     
- Misses        474      538      +64     
Flag Coverage Δ
python 88.27% <ø> (-0.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 88.27% <ø> (-0.69%) ⬇️
libtiledbsoma ∅ <ø> (∅)

@nguyenv nguyenv merged commit c7c33c9 into main Oct 1, 2024
15 checks passed
@nguyenv nguyenv deleted the viviannguyen/arrow_is_string_type branch October 1, 2024 23:04
johnkerl pushed a commit that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants