Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor update to .gitignore #3103

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Minor update to .gitignore #3103

merged 1 commit into from
Oct 1, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Oct 1, 2024

Long-standing minor annoyance: rg wasn't showing me some things in our pybind11 source unless I did rg -u. Today I finally got around to figuring out why. Our current .gitignore rule was masking apis/python/src/tiledbsoma/pytiledbsoma.cc.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.22%. Comparing base (40e2178) to head (3942cb1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3103       +/-   ##
===========================================
- Coverage   88.95%   63.22%   -25.73%     
===========================================
  Files          45      111       +66     
  Lines        4293    13663     +9370     
  Branches        0      851      +851     
===========================================
+ Hits         3819     8639     +4820     
- Misses        474     4815     +4341     
- Partials        0      209      +209     
Flag Coverage Δ
libtiledbsoma 51.37% <ø> (?)
python 89.09% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.09% <ø> (+0.13%) ⬆️
libtiledbsoma 49.92% <ø> (∅)

Copy link
Member

@ryan-williams ryan-williams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, take or leave

.gitignore Show resolved Hide resolved
@johnkerl johnkerl merged commit 140bf0b into main Oct 1, 2024
15 checks passed
@johnkerl johnkerl deleted the kerl/gitignore-tweak branch October 1, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants