Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Use same default max domain between Python and R #3088

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

johnkerl
Copy link
Member

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

In Python we were trying to use default max shapes there were 31-bit friendly for R compatibility. However, in R we're already setting 63-bit maxdomain:
https://github.com/single-cell-data/TileDB-SOMA/blob/1.14.1/apis/r/R/utils-arrow.R#L127

Notes for Reviewer:

@johnkerl johnkerl force-pushed the kerl/max-domain-int64 branch from c285f12 to 413e34d Compare September 28, 2024 14:44
@johnkerl johnkerl force-pushed the kerl/max-domain-int64 branch 2 times, most recently from 348d942 to 1561810 Compare September 29, 2024 04:45
@johnkerl johnkerl requested a review from nguyenv September 29, 2024 04:46
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.12%. Comparing base (06cb313) to head (c37530d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3088      +/-   ##
==========================================
+ Coverage   88.98%   89.12%   +0.14%     
==========================================
  Files          45       45              
  Lines        4286     4287       +1     
==========================================
+ Hits         3814     3821       +7     
+ Misses        472      466       -6     
Flag Coverage Δ
python 89.12% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.12% <100.00%> (+0.14%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl force-pushed the kerl/max-domain-int64 branch from 1561810 to c37530d Compare September 30, 2024 16:53
@johnkerl
Copy link
Member Author

Thanks @nguyenv and @mojaveazure ! :)

@johnkerl johnkerl merged commit efd323d into main Sep 30, 2024
20 of 21 checks passed
@johnkerl johnkerl deleted the kerl/max-domain-int64 branch September 30, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants