[python] Update TileDB-SOMA to use the somacore release with spatial datatypes
#3078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These types are needed as placeholders for the type checking in `Experiment` and `Measurement`.
johnkerl
changed the title
somacore release with spatial datatypes
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3078 +/- ##
==========================================
- Coverage 89.79% 89.16% -0.63%
==========================================
Files 41 45 +4
Lines 4107 4284 +177
==========================================
+ Hits 3688 3820 +132
- Misses 419 464 +45
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nguyenv
reviewed
Sep 27, 2024
aaronwolen
approved these changes
Sep 27, 2024
Co-authored-by: Aaron Wolen <[email protected]> Co-authored-by: nguyenv <[email protected]>
johnkerl
reviewed
Sep 27, 2024
Co-authored-by: John Kerl <[email protected]>
aaronwolen
reviewed
Sep 27, 2024
Co-authored-by: Aaron Wolen <[email protected]>
aaronwolen
reviewed
Sep 27, 2024
aaronwolen
reviewed
Sep 27, 2024
aaronwolen
reviewed
Sep 27, 2024
jp-dark
commented
Sep 27, 2024
Co-authored-by: Aaron Wolen <[email protected]>
aaronwolen
reviewed
Sep 27, 2024
aaronwolen
reviewed
Sep 27, 2024
Co-authored-by: Aaron Wolen <[email protected]>
This was referenced Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates somacore and adds the new spatial types to TileDB-SOMA as empty classes that throw
NotImplementedErrors. It updatesExperimentandMeasurementto match the updated somacore API.Issues: #3043 #3042