Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r] Push dimnames down to C++ #3065

Merged
merged 2 commits into from
Sep 27, 2024
Merged

[r] Push dimnames down to C++ #3065

merged 2 commits into from
Sep 27, 2024

Conversation

johnkerl
Copy link
Member

Issue and/or context: #3058, first of a few PRs here

Changes:

Notes for Reviewer:

@johnkerl johnkerl force-pushed the kerl/r-dimnames-pushdown branch from d9ade72 to f6df9b2 Compare September 25, 2024 15:03
mojaveazure
mojaveazure requested changes Sep 25, 2024
View reviewed changes
Copy link
Member

@mojaveazure mojaveazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some odd stuff going on with documentation in R/RcppExports.R; I don't know if this is from Rcpp or done manually but should be corrected

apis/r/R/RcppExports.R Outdated Show resolved Hide resolved
@johnkerl johnkerl force-pushed the kerl/r-dimnames-pushdown branch from 972805c to 32b577e Compare September 26, 2024 23:33
@johnkerl
Copy link
Member Author

There's some odd stuff going on with documentation in R/RcppExports.R; I don't know if this is from Rcpp or done manually but should be corrected

Fixed in #3071

@johnkerl
Copy link
Member Author

@mojaveazure not bumping DESCRIPTION and NEWS.md since this has no user-facing impact

@johnkerl johnkerl merged commit 5db8222 into main Sep 27, 2024
14 checks passed
@johnkerl johnkerl deleted the kerl/r-dimnames-pushdown branch September 27, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mojaveazure mojaveazure mojaveazure approved these changes

@nguyenv nguyenv Awaiting requested review from nguyenv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnkerl @mojaveazure