-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python/r] Expose shape-related accessors to Python/R bindings #2953
Conversation
ba528ba
to
021ed67
Compare
6cbe435
to
6dba46b
Compare
6dba46b
to
8ef6cf4
Compare
195240b
to
2a9f119
Compare
448dd7a
to
06aac21
Compare
6e2b8ce
to
5c09c72
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2953 +/- ##
===========================================
- Coverage 89.87% 61.31% -28.57%
===========================================
Files 38 93 +55
Lines 3999 12417 +8418
Branches 0 781 +781
===========================================
+ Hits 3594 7613 +4019
- Misses 405 4606 +4201
- Partials 0 198 +198
Flags with carried forward coverage won't be shown. Click here to find out more.
|
5c09c72
to
465e9a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the Python side.
@mojaveazure can you please take a look at the R side? Thank you! |
bac2027
to
5312d49
Compare
Thanks @nguyenv and @mojaveazure ! |
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
shape
for component arrays #2407_maybe_sjid_shape
and_maybe_sjid_maxshape
accessors will be crucial for experiment-level resize logic as on append mode, which does not yet exist in TileDB-SOMA-R (see [r] Port append-mode logic #1630)Notes for Reviewer: