Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Unit-test variant-indexed dataframes #2944

Merged
merged 5 commits into from
Sep 3, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions libtiledbsoma/src/soma/soma_array.h
Original file line number Diff line number Diff line change
Expand Up @@ -796,6 +796,13 @@ class SOMAArray : public SOMAObject {
*/
std::optional<TimestampRange> timestamp();

/**
* Exposed for testing purposes.
*/
CurrentDomain get_current_domain() {
return _get_current_domain();
}

private:
//===================================================================
//= private non-static
Expand Down
5 changes: 2 additions & 3 deletions libtiledbsoma/src/utils/arrow_adapter.cc
Original file line number Diff line number Diff line change
Expand Up @@ -868,9 +868,8 @@ ArraySchema ArrowAdapter::tiledb_schema_from_arrow_schema(
// nullptr)
//
// Fortunately, these are ASCII dims and we can range
// these accordingly. These are minimum and maximum
// values, avoiding the extremes 0x00 and 0xff.
ndrect.set_range(col_name, "\x01", "\xfe");
// these accordingly.
ndrect.set_range(col_name, "", "\xff");
} else {
const void* buff = index_column_array->children[i]
->buffers[1];
Expand Down
2 changes: 1 addition & 1 deletion libtiledbsoma/test/common.cc
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ static std::unique_ptr<ArrowArray> _create_index_cols_info_array(
std::memcpy((void*)dim_array->buffers[1], vsrc, nbytes);
} else {
// domain small; current_domain feature not being used
int64_t dom[] = {0, info.dim_max, 1};
uint32_t dom[] = {0, (uint32_t)info.dim_max, 1};
void* vsrc = (void*)&dom[0];
std::memcpy((void*)dim_array->buffers[1], vsrc, nbytes);
}
Expand Down
Loading
Loading