Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] Include guidance for older CPU architectures #2643

Merged
merged 2 commits into from
May 25, 2024
Merged

[python] Include guidance for older CPU architectures #2643

merged 2 commits into from
May 25, 2024

Conversation

johnkerl
Copy link
Member

Resolves #2580.

@johnkerl johnkerl mentioned this pull request May 24, 2024
Closed
@eddelbuettel
Copy link
Contributor

Suggestion: Maybe we should a hint there or on the wiki that helps identify the issue. In the case at hand here as well as in the earlier case it was that grep avx2 /proc/cpuinfo came up empty as the machines were in fact pre-AVX2 and that happens to be a CMake check we have in Core.

@johnkerl johnkerl requested a review from eddelbuettel May 24, 2024 19:46
@johnkerl
Copy link
Member Author

Thanks @eddelbuettel ! 7f08fae

@johnkerl johnkerl merged commit 2276269 into main May 25, 2024
1 check passed
@johnkerl johnkerl deleted the kerl/older-arch-advice branch May 25, 2024 19:45
johnkerl added a commit that referenced this pull request May 30, 2024
@johnkerl
[python] Include guidance for older CPU architectures (#2643)
7b66087 
* [python] Include guidance for older CPU architectures

* code-review feedback
@johnkerl johnkerl mentioned this pull request May 30, 2024
Merged
johnkerl added a commit that referenced this pull request May 30, 2024
@johnkerl
[python] Include guidance for older CPU architectures (#2643) (#2656)
d8c21e2 
* [python] Include guidance for older CPU architectures

* code-review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronwolen aaronwolen aaronwolen approved these changes

@ryan-williams ryan-williams Awaiting requested review from ryan-williams

@eddelbuettel eddelbuettel Awaiting requested review from eddelbuettel

Assignees
No one assigned
Labels
backport release-1.11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Develop guidance for support for older linux-x86 processor variants
3 participants
@johnkerl @eddelbuettel @aaronwolen