[r] Two-sided R pin for release-1.10 branch; backport #2540, #2546, #2549
#2549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
changed the title
release-2.10 branchrelease-1.10 branch
|
If tiledbsoma 1.10 uses core 2.22/tiledb-r 0.26, then in addition to the following change we'll also need #2540 and #2546 backported to As shown previously, the doublepin does not affect installation or library loading, only |
This was referenced May 13, 2024
* merge * merge (#2551) Co-authored-by: Paul Hoffman <[email protected]> --------- Co-authored-by: Paul Hoffman <[email protected]>
johnkerl
changed the title
release-1.10 branchrelease-1.10 branch; backport #2540, #2546, #2549
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.10 #2549 +/- ##
=============================================
Coverage 90.21% 90.21%
=============================================
Files 37 37
Lines 3966 3966
=============================================
Hits 3578 3578
Misses 388 388
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
commented
May 13, 2024
| @@ -82,7 +99,7 @@ jobs: | |||
| # run: cd apis/r && Rscript -e "options(bspm.version.check=TRUE); install.packages('tiledb', repos = c('https://eddelbuettel.r-universe.dev/bin/linux/jammy/4.3/', 'https://cloud.r-project.org'))" | |||
|
|
|||
| - name: Dependencies | |||
| run: cd apis/r && tools/r-ci.sh install_all | |||
| run: cd apis/r && Rscript -e "remotes::install_deps(dependencies = TRUE, upgrade = FALSE)" | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Not necessarily, the "." is the default https://remotes.r-lib.org/reference/install_deps.html
mojaveazure
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: Following our established procedure, I am working on tiledbsoma 1.11 today
[sc-46600]
Changes:
Notes for Reviewer:
@mojaveazure I am following https://github.com/single-cell-data/TileDB-SOMA/wiki/Branches-and-releases#incrementing-core-versions
However, since that was updated we do have #2540 and #2546 on
main; I'm not sure what's the right thing to do here on therelease-1.10branch, as I am going to create arelease-1.11branch today -- @mojaveazure let's work together on this.