Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use core 2.23.0, TileDB-Py 0.29.0, TileDB-R 0.27.0 #2548

Merged
merged 1 commit into from
May 10, 2024

Conversation

johnkerl
Copy link
Member

Issue and/or context: [sc-46600]

Changes:

Notes for Reviewer:

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.21%. Comparing base (18c3e6c) to head (050e95a).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2548       +/-   ##
===========================================
+ Coverage   61.31%   90.21%   +28.90%     
===========================================
  Files          91       37       -54     
  Lines        9388     3975     -5413     
  Branches      564        0      -564     
===========================================
- Hits         5756     3586     -2170     
+ Misses       3539      389     -3150     
+ Partials       93        0       -93     
Flag Coverage Δ
libtiledbsoma ?
python 90.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 90.21% <ø> (ø)
libtiledbsoma ∅ <ø> (∅)

Copy link
Contributor

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same sha1-version information is copied to 15 places. It really would be cleaner (and likely also more robust) to store in (ideally just) one place and use that.

@johnkerl
Copy link
Member Author

johnkerl commented May 10, 2024

The same sha1-version information is copied to 15 places. It really would be cleaner (and likely also more robust) to store in (ideally just) one place and use that.

@eddelbuettel we have discussed this before. scripts/update-tilebs-version.py 2.23.0 automates this process in a single, non-error-prone step. I do releases and I'm 100% delighted with the ease of use.

@johnkerl johnkerl merged commit 4ad8f25 into main May 10, 2024
35 checks passed
@johnkerl johnkerl deleted the kerl/2.23.0-0.29.0-0.27.0 branch May 10, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants