Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++,python] Remove tiledb-py for all arrays #2498

Merged
merged 1 commit into from
May 7, 2024

Conversation

nguyenv
Copy link
Member

@nguyenv nguyenv commented Apr 30, 2024

Issue and/or context:

#2241

This completes the moveover for SOMAArrays to use clib.SOMAArray instead of tiledb-py arrays.

Changes:

  • Add vacuuming and consolidation to C++
  • Remove TileDB ArraySchema creation
  • Rename TileDBArray to SOMAArray to reflect that arrays are no longer TileDB-Py arrays but clib.SOMAArray

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 90.25%. Comparing base (5a442af) to head (05d4440).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2498      +/-   ##
==========================================
+ Coverage   89.23%   90.25%   +1.01%     
==========================================
  Files          37       37              
  Lines        4024     3950      -74     
==========================================
- Hits         3591     3565      -26     
+ Misses        433      385      -48     
Flag Coverage Δ
python 90.25% <76.00%> (+1.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 90.25% <76.00%> (+1.01%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@nguyenv nguyenv force-pushed the viviannguyen/move-vac-to-cpp branch from 0fa83a8 to c9369cd Compare May 1, 2024 22:33
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nguyenv nguyenv force-pushed the viviannguyen/dense-write-path-python branch from 7918346 to da4a15d Compare May 6, 2024 16:31
Base automatically changed from viviannguyen/dense-write-path-python to main May 6, 2024 20:57
* Add vacuuming and consolidation to C++
* Remove TileDB ArraySchema creation
* Rename TileDBArray to SOMAArray to reflect that arrays are no
  longer TileDB-Py arrays but clib.SOMAArray
@nguyenv nguyenv force-pushed the viviannguyen/move-vac-to-cpp branch from 149f031 to 05d4440 Compare May 6, 2024 23:39
@nguyenv nguyenv merged commit 676c834 into main May 7, 2024
15 checks passed
@nguyenv nguyenv deleted the viviannguyen/move-vac-to-cpp branch May 7, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants