Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Support cmake-verbose flag in Makefile #2495

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Apr 30, 2024

The current build=Debug flag to make controls symbols in binary artifacts. We lack a standard way to set verbosity for cmake so that Makefiles will show full compile lines when executed. These two things are orthogonal to one another, and they are both important.

This is crucial for customer support, e.g. on #2402 it was necessary to ask an end user to do a manual edit. This is not sustainable.

Likewise, developers doing sandbox debug often don't need full compile lines hidden from them (which is the default).

A few of us have independently modded this in sandbox. A due appreciation for use of people's time compels us to make this a resuable option in source control.

Example default output: https://gist.github.com/johnkerl/26b4ac9cdb58e17f4bc595f2c174338a

Example cmake-verbose output: https://gist.github.com/johnkerl/fea6dcca26f6b76d117a72d8cc29a7e5

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (20803cf) to head (c82dca8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2495   +/-   ##
=======================================
  Coverage   89.87%   89.87%           
=======================================
  Files          37       37           
  Lines        3940     3940           
=======================================
  Hits         3541     3541           
  Misses        399      399           
Flag Coverage Δ
python 89.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 89.87% <ø> (ø)
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl merged commit 65e6baf into main Apr 30, 2024
15 checks passed
@johnkerl johnkerl deleted the kerl/cmake-verbose branch April 30, 2024 13:39
github-actions bot pushed a commit that referenced this pull request Apr 30, 2024
johnkerl added a commit that referenced this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants