[python,c++] Use C++ DenseNDArray bindings in Python API
#2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
changed the title
DenseNDArray bindings in Python API
nguyenv
changed the title
DenseNDArray bindings in Python APIDenseNDArray bindings in Python API
nguyenv
commented
Apr 30, 2024
johnkerl
approved these changes
May 2, 2024
nguyenv
force-pushed
the
viviannguyen/ndarray-write-path
branch
2 times, most recently
from
7f7224a to
d684b45
Compare
* Also modify SOMA typechecks to be case insensitive * Throw domain error as ValueError * Add `_util.cast_values_to_target_schema`, `map_exception_for_create` and `pyarrow_to_carrow_type` * Remove `tiledb.open` from `used_shape`
nguyenv
force-pushed
the
viviannguyen/dense-write-path-python
branch
from
7918346 to
da4a15d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2494 +/- ##
==========================================
- Coverage 90.12% 89.23% -0.89%
==========================================
Files 37 37
Lines 3979 4024 +45
==========================================
+ Hits 3586 3591 +5
- Misses 393 433 +40
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context:
#2429