Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python][spatial] Implement Scene class in Python #2485

Merged
merged 5 commits into from
May 2, 2024
Merged

Conversation

jp-dark
Copy link
Collaborator

@jp-dark jp-dark commented Apr 25, 2024

Issue and/or context:
#2484

Changes:
Add Python Scene class that implements the abc class in somacore.

Notes for Reviewer:
This is a prototype for the spatial work. Do not merge into main.

@jp-dark
Copy link
Collaborator Author

jp-dark commented Apr 25, 2024

[sc-43825]

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 45.16129% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 87.81%. Comparing base (8f4d36f) to head (c5f1b06).

Additional details and impacted files
@@             Coverage Diff             @@
##           spatial    #2485      +/-   ##
===========================================
- Coverage    87.97%   87.81%   -0.17%     
===========================================
  Files           39       40       +1     
  Lines         4025     4046      +21     
===========================================
+ Hits          3541     3553      +12     
- Misses         484      493       +9     
Flag Coverage Δ
python 87.81% <45.16%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 87.81% <45.16%> (-0.17%) ⬇️
libtiledbsoma ∅ <ø> (∅)

@jp-dark jp-dark changed the title Implement Scene class in Python [python][spatial] Implement Scene class in Python Apr 29, 2024
@jp-dark jp-dark merged commit f09c465 into spatial May 2, 2024
31 checks passed
@jp-dark jp-dark deleted the dark/scene branch May 2, 2024 13:14
jp-dark added a commit that referenced this pull request May 3, 2024
* Update somacore version for Python API and pre-commit to use GitHub commit/branch
* Add Scene class to Python implementation
* Use Scene in visium ingestion

Co-authored-by: Paul Fisher <[email protected]>

---------

Co-authored-by: Paul Fisher <[email protected]>
jp-dark added a commit that referenced this pull request May 7, 2024
* Update somacore version for Python API and pre-commit to use GitHub commit/branch
* Add Scene class to Python implementation
* Use Scene in visium ingestion

Co-authored-by: Paul Fisher <[email protected]>

---------

Co-authored-by: Paul Fisher <[email protected]>
jp-dark added a commit that referenced this pull request May 13, 2024
* Update somacore version for Python API and pre-commit to use GitHub commit/branch
* Add Scene class to Python implementation
* Use Scene in visium ingestion

Co-authored-by: Paul Fisher <[email protected]>

---------

Co-authored-by: Paul Fisher <[email protected]>
jp-dark added a commit that referenced this pull request May 21, 2024
* Update somacore version for Python API and pre-commit to use GitHub commit/branch
* Add Scene class to Python implementation
* Use Scene in visium ingestion

Co-authored-by: Paul Fisher <[email protected]>

---------

Co-authored-by: Paul Fisher <[email protected]>
jp-dark added a commit that referenced this pull request May 29, 2024
* Update somacore version for Python API and pre-commit to use GitHub commit/branch
* Add Scene class to Python implementation
* Use Scene in visium ingestion

Co-authored-by: Paul Fisher <[email protected]>

---------

Co-authored-by: Paul Fisher <[email protected]>
jp-dark added a commit that referenced this pull request Jun 3, 2024
* Update somacore version for Python API and pre-commit to use GitHub commit/branch
* Add Scene class to Python implementation
* Use Scene in visium ingestion

Co-authored-by: Paul Fisher <[email protected]>

---------

Co-authored-by: Paul Fisher <[email protected]>
jp-dark added a commit that referenced this pull request Jun 12, 2024
* Update somacore version for Python API and pre-commit to use GitHub commit/branch
* Add Scene class to Python implementation
* Use Scene in visium ingestion

Co-authored-by: Paul Fisher <[email protected]>

---------

Co-authored-by: Paul Fisher <[email protected]>
jp-dark added a commit that referenced this pull request Jul 12, 2024
* Update somacore version for Python API and pre-commit to use GitHub commit/branch
* Add Scene class to Python implementation
* Use Scene in visium ingestion

Co-authored-by: Paul Fisher <[email protected]>

---------

Co-authored-by: Paul Fisher <[email protected]>
jp-dark added a commit that referenced this pull request Jul 17, 2024
* Update somacore version for Python API and pre-commit to use GitHub commit/branch
* Add Scene class to Python implementation
* Use Scene in visium ingestion

Co-authored-by: Paul Fisher <[email protected]>

---------

Co-authored-by: Paul Fisher <[email protected]>
jp-dark added a commit that referenced this pull request Jul 23, 2024
* Update somacore version for Python API and pre-commit to use GitHub commit/branch
* Add Scene class to Python implementation
* Use Scene in visium ingestion

Co-authored-by: Paul Fisher <[email protected]>

---------

Co-authored-by: Paul Fisher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant