Use core 2.22.0, TileDB-Py 0.28.0, TileDB-R 0.26.0 on main branch
#2448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
changed the title
|
[sc-44519] |
johnkerl
changed the title
main branch
nguyenv
approved these changes
Apr 16, 2024
eddelbuettel
approved these changes
Apr 16, 2024
| @@ -34,7 +34,7 @@ Imports: | |||
| Matrix, | |||
| stats, | |||
| bit64, | |||
| tiledb (>= 0.25.0), | |||
| tiledb (>= 0.26.0), | |||
There was a problem hiding this comment.
It may make sense to put more than one inequality here as we know that a future (higher) tiledb (R) package may bring an unsuitable (newer) TileDB Embedded version.
There was a problem hiding this comment.
@eddelbuettel thanks! For now -- on main -- there is no higher version -- 0.26.0 just came into existence this week. And for "beyond that" we do indeed have a WIP going here #2374 and once that WIP is fully fleshed out and proceduralized, watch for further changes upcoming. There will be more changes coming today/tomorrow, and after that.
johnkerl
added a commit
that referenced
this pull request
Apr 16, 2024
This was referenced Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: Following our established procedure
Changes:
Notes for Reviewer: This PR is not ready for review. First I will look for green CI.