[python] Check for uniqueness of registration obs/var field-name inputs #2380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2380 +/- ##
===========================================
+ Coverage 66.72% 90.61% +23.88%
===========================================
Files 142 37 -105
Lines 12708 3898 -8810
Branches 511 0 -511
===========================================
- Hits 8480 3532 -4948
+ Misses 4128 366 -3762
+ Partials 100 0 -100
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
force-pushed
the
kerl/dup-coords-check
branch
from
d979165 to
7b65232
Compare
johnkerl
force-pushed
the
kerl/dup-coords-check
branch
from
7b65232 to
89ee20d
Compare
|
[sc-44549] |
|
This pull request has been linked to Shortcut Story #44549: Duplicate error during SOMA experiment ingestion. |
johnkerl
changed the title
ryan-williams
approved these changes
Apr 4, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 4, 2024
…ts (#2380) * [python] Check for uniqueness of registration obs/var field-name inputs * conditional contextmanager for boilerplate reduction --------- Co-authored-by: Ryan Williams <[email protected]>
johnkerl
added a commit
that referenced
this pull request
Apr 4, 2024
…ts (#2380) (#2385) * [python] Check for uniqueness of registration obs/var field-name inputs * conditional contextmanager for boilerplate reduction --------- Co-authored-by: John Kerl <[email protected]> Co-authored-by: Ryan Williams <[email protected]>
|
[sc-44675] |
|
This pull request has been linked to Shortcut Story #44675: tiledbsoma 1.9.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: When non-unique values are present in
obsorvarthen append-mode ingest, if it uses that non-uniquely-valued field name as registration inputs, will fail at ingestion time withThis problem happens during the data write.
Changes:
The error should be surfaced earlier, at registration time:
Notes for Reviewer: