-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Add back deprecated function tiledbsoma_build_index
#2344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thetorpedodog
approved these changes
Mar 27, 2024
bkmartinjr
approved these changes
Mar 27, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2344 +/- ##
===========================================
+ Coverage 78.68% 90.56% +11.88%
===========================================
Files 140 37 -103
Lines 10760 3879 -6881
Branches 217 0 -217
===========================================
- Hits 8466 3513 -4953
+ Misses 2195 366 -1829
+ Partials 99 0 -99
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
approved these changes
Mar 27, 2024
Spurious MacOS so-copy CI fail is a KP #2237 -- I restarted it |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
* Add back deprecated function `tiledbsoma_build_index` * Add function to __all__
github-actions bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
* Add back deprecated function `tiledbsoma_build_index` * Add function to __all__
johnkerl
pushed a commit
that referenced
this pull request
Mar 27, 2024
* Add back deprecated function `tiledbsoma_build_index` * Add function to __all__ Co-authored-by: Julia Dark <[email protected]>
johnkerl
pushed a commit
that referenced
this pull request
Mar 27, 2024
* Add back deprecated function `tiledbsoma_build_index` * Add function to __all__ Co-authored-by: Julia Dark <[email protected]>
johnkerl
changed the title
Add back deprecated function
[python] Add back deprecated function Mar 27, 2024
tiledbsoma_build_index
tiledbsoma_build_index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: #2343
Changes:
Restore function
tiledbsoma_build_index
. Deprecate instead of removing.