[python] Neaten registration-mapping test code #2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
force-pushed
the
kerl/registration-test-neaten
branch
from
c51969f to
d0a2e30
Compare
johnkerl
force-pushed
the
kerl/registration-test-neaten
branch
from
d0a2e30 to
619caf5
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2285 +/- ##
===========================================
+ Coverage 78.89% 90.94% +12.05%
===========================================
Files 139 36 -103
Lines 10718 3845 -6873
Branches 215 0 -215
===========================================
- Hits 8456 3497 -4959
+ Misses 2164 348 -1816
+ Partials 98 0 -98
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
changed the title
ryan-williams
approved these changes
Mar 18, 2024
|
e605dbc -- thank you @ryan-williams ! |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 18, 2024
* [python] Neaten registration-mapping test code * code-review feedback [skip-ci]
johnkerl
added a commit
that referenced
this pull request
Mar 18, 2024
* [python] Neaten registration-mapping test code * code-review feedback [skip-ci] Co-authored-by: John Kerl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: Issue #2242
Changes: This is some factoring to help simplify #2281, which will be rebased on top of this PR.
Notes for Reviewer: