-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[r/ci] Set options(pkgType = "binary")
for MacOS
#2257
Conversation
Force binary-only installation for macOS. By setting as an option in `~/.Rprofile`; this should affect both package installation and updating through `utils::install.packages()`, `utils::update.packages()`, and `remotes::install_deps()` resolves #2254
What about the two packages we only have as source:
Maybe we need to toss them into a r-universe to have binaries too (and then Additional_repositories: point to that) ? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2257 +/- ##
==========================================
+ Coverage 78.60% 78.85% +0.24%
==========================================
Files 139 139
Lines 10704 10730 +26
Branches 215 215
==========================================
+ Hits 8414 8461 +47
+ Misses 2192 2171 -21
Partials 98 98
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Yeah, just saw that. Alternatively, a stanza à la - name: Install dataset packages from source (macOS)
if: ${{ matrix.os == 'macOS-latest' }}
run: remotes::install_deps(dependencies = "Suggests", type = "source", upgrade = FALSE)
shell: Rscript {0} could work as well, without changing any package distribution machinery |
options(pkgType = "binary")
for macOSoptions(pkgType = "binary")
for MacOS
Note: As the two pbmc3k dataset packages are source-only, I've added a new stanza to install these separately on macOS. This calls a separate R script
This stanza runs on macOS only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to me from the release-management point of view!! :) CI is green and I am happy
I defer to @eddelbuettel on the implementation details ...
I'll stay out of it. I provided a much simpler code example to @mojaveazure that attacked a simpler sub-task and that is what I might have done, but I didn't and I won't rewrite this. If it works it works. |
* [r/ci] Set `options(pkgType = "binary")` for macOS Force binary-only installation for macOS. By setting as an option in `~/.Rprofile`; this should affect both package installation and updating through `utils::install.packages()`, `utils::update.packages()`, and `remotes::install_deps()` resolves #2254
* [r/ci] Set `options(pkgType = "binary")` for macOS Force binary-only installation for macOS. By setting as an option in `~/.Rprofile`; this should affect both package installation and updating through `utils::install.packages()`, `utils::update.packages()`, and `remotes::install_deps()` resolves #2254 Co-authored-by: Paul Hoffman <[email protected]>
Force binary-only installation for macOS. By setting as an option in
~/.Rprofile
; this should affect both package installation and updating throughutils::install.packages()
,utils::update.packages()
, andremotes::install_deps()
resolves #2254