-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python/ci] Restore pre-merge lint checks #2247
Conversation
Ohhhhhh :headdesk: ... this is my bad, thanks for catching it @ryan-williams !! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2247 +/- ##
==========================================
+ Coverage 78.54% 78.79% +0.24%
==========================================
Files 137 137
Lines 10684 10710 +26
Branches 215 215
==========================================
+ Hits 8392 8439 +47
+ Misses 2194 2173 -21
Partials 98 98
Flags with carried forward coverage won't be shown. Click here to find out more.
|
2nd commit here fixes lint-rot that crept in last week (causing python-ci-full failures), xref #2236, #2047 |
I made #2248 to track |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-1.8 release-1.8
# Navigate to the new working tree
cd .worktrees/backport-release-1.8
# Create a new branch
git switch --create backport-2247-to-release-1.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 874ccb2540706132c624dc6c81823152bb9a3342
# Push it to GitHub
git push --set-upstream origin backport-2247-to-release-1.8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-1.8 Then, create a pull request where the |
Issue and/or context: #2238 (comment)
Tracking issue: #2248
3.10 was removed from the CI matrix, but the lint/codecov conditions were not updated, inadvertently removing those checks from pre-merge CI.